Re: FAIL: five tests on trunk - now only two

Quoting Julian Foad <julianfoad_at_btopenworld.com>:

> On Tue, 2008-11-04 at 19:39 +0000, Julian Foad wrote:

> Still failing on RA-svn are:
>
> FAIL: commit_tests.py 28: commit deletion of out-of-date file or dir
> FAIL: merge_authz_tests.py 1: skipped paths get overriding mergeinfo
>
>
>> Initial investigation:
>>
>> **********
>>
>> FAIL: commit_tests.py 28: commit deletion of out-of-date file or dir
>>
>> This test is failing to see the "out of date" error from a commit,
>> instead seeing the less helpful "File not found: transaction '3-4', path
>> '/A/I'". The "out of date" error occurs with RA-local, but this is with
>> RA-svn. See r33994 which changed the error message (in RA-local at
>> least) and change the test's expectation accordingly.
>>
>> [[[
>> EXPECTED STDERR (regexp):
>> .*(out of date)
>> ACTUAL STDERR:
>> /home/julianfoad/src/subversion-trunk3/subversion/libsvn_client/commit.c:864:
>> (apr_err=160013)
>> svn: Commit failed (details follow):
>> /home/julianfoad/src/subversion-trunk3/subversion/libsvn_fs_fs/tree.c:661:
>> (apr_err=160013)
>> svn: File not found: transaction '3-4', path '/A/I'
>> ]]]

This test passes over http. I'll update the XFail().

The failure over ra_svn occurs upon closing the editor, which
(to me) is surprisingly late.

Specifically, in ra_svn_close_edit(), the server response "File
not found" is discovered by calling svn_ra_svn_read_cmd_response().

None of the other callbacks read the server responses. Does the
server really say nothing about the failing commit until it's
over?

The other access methods detect a failed open_{root,dir,file}
right away, AFAIK.

Any ra_svn gurus care to comment?

Thanks,
Steve

-- 
Stephen Butler | Software Developer
elego Software Solutions GmbH
Gustav-Meyer-Allee 25 | 13355 Berlin | Germany
fon: +49 30 2345 8696 | mobile: +49 163 25 45 015
fax: +49 30 2345 8695 | http://www.elegosoft.com
Geschäftsführer: Olaf Wagner | Sitz der Gesellschaft: Berlin
Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org