Re: svn commit: r34018 - in trunk/subversion: include libsvn_client libsvn_wc

On Sun, 2008-11-02 at 20:40 -0800, neels_at_tigris.org wrote:
> Author: neels
> Date: Sun Nov 2 20:40:11 2008
> New Revision: 34018
>
> Log:
> Remove the dir_closed() diff callback, it is now unused everywhere.

Hi Neels.

Reasons for removing the USES of this callback: because there's nothing
we want them to do at the moment. Agreed. Thanks for pruning that dead
code.

Reasons for removing the API and DRIVER of this callback: because we
don't believe it's a sensible and supportable feature, or we don't
believe that there can be any good use for it in the 1.6.x time frame.
I'm not aware of any such reasons. I think the dir_closed() callback is
a sensible complement to dir_opened(), and removing it may cause us
problems when we want to fix tree conflict handling bugs in 1.6.x time
frame.

What do you think?

I notice also that we need to update the documentation for the
diff_callbacks3_t and diff_callbacks2_t. They mention dir_opened and
dir_closed, but they don't say when those functions are called relative
to the other functions, and they don't mention the "tree_conflicted"
parameter that is present in most of the diff_callbacks3_t functions.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-03 12:30:25 CET