[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33989

From: Neels J. Hofmeyr <neels_at_elego.de>
Date: Mon, 03 Nov 2008 04:53:20 +0100

Karl Fogel wrote:
> After this change, trunk Subversion gets many warnings like this:
>
> subversion/libsvn_wc/deprecated.c:643: warning: \
> initialization from incompatible pointer type
>
> It's because in subversion/libsvn_wc/deprecated.c, we already have this
> code:
>
> static struct svn_wc_diff_callbacks3_t callbacks_wrapper = {
> file_changed,
> file_added,
> file_deleted,
> dir_added,
> etc, ...
> }
>
> r33989 changed 'svn_wc_diff_callbacks3_t' by adding a new parameter
> (TREE_CONFLICTED) to many of its callback functions. But the static
> functions in deprecated.c were never updated with the new parameter --
> thus, they give a warning when used in those positions in the struct.
>
> -Karl

Ah, thanks for finding this. I firmly remember to have made the change, but
I must have forgotten to commit it. (And I kept ignoring the compiler
warnings because it said "deprecated" in them. Wasn't reading properly.)

Fixed in r34017.

BTW, shouldn't the compiler bail out on this kind of error instead of just
warning about it? It causes a function call with bogus parameters, that's
real bad.

~Neels

Received on 2008-11-03 04:53:41 CET

This is an archived mail posted to the Subversion Dev mailing list.