[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 3272 ( suggestion )

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 30 Oct 2008 23:26:59 +0200 (Jerusalem Standard Time)

Ping.

On a quick scan, you don't check the "assuming that the checkout is of the
same URL that the existing wc represents" part described in the issue.
(You want to check that the directory is version and from the same
URL/repository/uuid as its parent.)

Also, the code (1) uses tabs, and (2) is wrongly indented (even in the
parts that use spaces). For (3), please don't use the *.c extension
for patches --- *.diff, *.patch, and *.txt are preferred. (All of these
are summarized at http://subversion.tigris.org/hacking.html, particularly
in hacking.html#patches.)

Thanks for the patch,

Daniel

Denis Pokataev wrote on Sun, 19 Oct 2008 at 17:36 +0400:
> Greetings,
>
> http://subversion.tigris.org/issues/show_bug.cgi?id=3272
>
> Patch suggestion is in attachment. It is allowing checkout of parent directory,
> but I'm not sure that it will not break something else,
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-30 22:27:09 CET

This is an archived mail posted to the Subversion Dev mailing list.