[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33863 - trunk/subversion/libsvn_wc

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Thu, 30 Oct 2008 14:08:20 -0500

Erik Huelsmann wrote:
> On Thu, Oct 23, 2008 at 4:58 PM, <hwright_at_tigris.org> wrote:
>> Author: hwright
>> Date: Thu Oct 23 07:58:58 2008
>> New Revision: 33863
>>
>> Log:
>> Followup to r33831: Just use the system temp directory for a temporary file.
>> In this case, the file isn't being atomically moved anywhere, just opened and
>> read again, so we don't really care where it lives.
>
> But, why not just send it into a stringbuf directly? I mean, we're
> diffing memory structures, writing it to disk in order to have it be
> read back 15 statements later into a stringbuf (which is used for
> later manipulation...). It would seem more efficient to skip the disk
> step.

Agreed that it's possible, but more than I want to think about right now. I'm
just a remove-the-deprecated-API monkey. ;)

-Hyrum

Received on 2008-10-30 20:08:43 CET

This is an archived mail posted to the Subversion Dev mailing list.