[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Redundant lines in do_entry_deletion()?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 29 Oct 2008 12:09:05 +0000

Can anyone see whether the following marked lines are redundant? It
looks to me like they are just re-setting the state of the existing
entry.

- Julian

trunk/subversion/libsvn_wc/update_editor.c

> @@ -1359,13 +1359,13 @@ do_entry_deletion(struct edit_baton *eb,
>
> tmp_entry.revision = *(eb->target_revision);
> tmp_entry.kind =
> - (entry->kind == svn_node_file) ? svn_node_file : svn_node_dir; /* ### redundant? */
> tmp_entry.deleted = TRUE;
>
> SVN_ERR(svn_wc__loggy_entry_modify(&log_item, adm_access,
> full_path, &tmp_entry,
> SVN_WC__ENTRY_MODIFY_REVISION
> - | SVN_WC__ENTRY_MODIFY_KIND /* ### redundant change? */
> | SVN_WC__ENTRY_MODIFY_DELETED,
> pool));
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-29 13:09:37 CET

This is an archived mail posted to the Subversion Dev mailing list.