[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33945 - trunk/subversion/libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 29 Oct 2008 04:46:59 -0700

On Wed, Oct 29, 2008 at 12:42 AM, <kameshj_at_tigris.org> wrote:
>...
> +++ trunk/subversion/libsvn_subr/opt.c Wed Oct 29 00:42:38 2008 (r33945)
> @@ -32,6 +32,7 @@
> #include "svn_version.h"
> #include "svn_types.h"
> #include "svn_opt.h"
> +#include "opt.h"
> #include "svn_error.h"
> #include "svn_path.h"
> #include "svn_utf.h"

That's a very strange place to put that header. We normally group headers like:

#include <stdlib.h> /* system headers */
#include <another.h>

#include <apr_pools.h> /* other package headers */
#include <apr_file_io.h>

#include "svn_types.h" /* our public headers */
#include "svn_error.h"

#include "opt.h" /* our private headers */
#include "checksum.h"

I think this would have also been evident from the file itself. Please
keep an eye out for stylistic conventions in whatever file you're
editing, and try to follow the same pattern.

Cheers,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-29 12:47:15 CET

This is an archived mail posted to the Subversion Dev mailing list.