[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Fix for renaming errors on Samba working copy

From: Alan Wood <alan.wood_at_clear.net.nz>
Date: Fri, 24 Oct 2008 23:00:00 +1300

Just an update on this issue:
 Samba Bug 5797 ( reported by Sebastian Krysmanksi ) has now been fixed in Samba
Version 3.3.0pre2. So this patch will no longer be needed once this version of Samba
makes it out into the real world. Could take some time for this to happen though so I
would still like to see this go though on the 1.5.x branch.

Alan

On 12 Oct 2008 at 21:15, dev_at_subversion.tigris.org wrote:

> Hi,
>
> Here is a slightly improved version of my work-around for Samba working copy
> failures. Using this patch does leave writable files in the .svn area but at least it
> allows you to use svn from both the Linux and Windows side of the share.
> My system that I have been working with:
> Windows XP SP3; RHEL 5; Samba 3.0.14;
>
> Would be nice to fix apr libraries and/or Samba to not have to do this. Hopefully the
> new working copy lay-out will not require this either.
>
> I would like to see this in the next 1.5.x release.
>
> Alan
>
> On 8 Oct 2008 at 23:44, Bert Huijben wrote:
>
> > On 8 Oct 2008 at 10:43, Bert Huijben wrote:
> >
> > >
> > > The retry loop checks the exact error. This code checks a boolean against
> > > several apr_status_t values ;)
> >
> > Actually the retry macro only sees the return form the apr_file_rename().
> > The comma operator protects it from the set_file_read_write.
> > I did miss the error clearing.
> > But that just proves its too hard to read which is why we don't want this version.
> >
> > > I think a helper function returning apr_status_t would be the best solution.
> >
> > I have attached a helper function for comment, but as I wont have time for lots
> > of testing till later in the week and I can't guarantee it at the moment, I guess its
> > missed 1.5.3.
> >
> > >
> > > The helper should clear the svn_error_t and return only the status. Or it
> > > should directly call apr to reset the attribute if that is an easier
> > > solution. (The cost of allocating an error is not an issue as we are
> > > delaying on the error anyway).
> > >
> > > Thanks,
> > > Bert
> > >
>
>
> Attachments:
> C:\alan\Samba investigation\rename patch only No 2\io.c.4.patch

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-24 12:00:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.