[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33855 - in branches/tree-conflicts-notify/subversion: include libsvn_client libsvn_wc svn tests/cmdline tests/cmdline/svntest

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 23 Oct 2008 01:59:24 -0700

On Wed, Oct 22, 2008 at 6:04 PM, <neels_at_tigris.org> wrote:
> Author: neels
> Date: Wed Oct 22 18:04:30 2008
> New Revision: 33855
>
> Log:
> On branch: tree-conflicts-notify
>
> *** This is just a start. Don't waste too much time reviewing it! ***
> *** Some parts of this may be misguided and go away again. ***

Neels,

EVERY commit should be fully-reviewed, and fully reviewable.

Why? The answer is simple. If a review is not performed, then *when*
should be it be done? We all agree reviews should be done, so then
when, if not when it first gets committed?

"Branch merge" is not the right answer. At that point, the overall
change will be too large to properly review.

This is the second or third time, I've seen your log message basically
say "don't bother to review this". I think that is an incorrect
procedure/direction, so I wanted to raise this point about reviewable
code. Also note this means you should consider your commits to a
branch to be just as focused, complete, and working as any commit you
would make to /trunk.

Thanks,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-23 10:59:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.