[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33816 - trunk/subversion/libsvn_fs_fs

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Tue, 21 Oct 2008 16:45:16 -0500

Greg Stein wrote:
> On Tue, Oct 21, 2008 at 7:53 AM, <hwright_at_tigris.org> wrote:
>> ...
>> +++ trunk/subversion/libsvn_fs_fs/rep-cache.c Tue Oct 21 07:53:45 2008 (r33816)
>> @@ -28,18 +28,16 @@
>> /* A few magic values */
>> #define REP_CACHE_SCHEMA_FORMAT 1
>>
>> -const char *upgrade_sql[] = { NULL,
>> +static const char *upgrade_sql[] = { NULL,
>
> oh. looks like an extra "const" ought to be in there, too. Right after the *
>
> Right now, it is classified as a non-const global.

Sounds good, r33818.

>> ...
>> + "create table rep_cache (hash text not null primary key, "
>
> not null is implied, but is (obviously) fine to leave in :-)
>
>> ...
>
> The caching of prepared statements looks good. I bet we can get some
> really clean stuff in just a couple more iterations, based on working
> more with the API.

Agreed.

-Hyrum

Received on 2008-10-21 23:45:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.