[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33792 - in trunk/subversion: libsvn_wc svn

From: Jens Seidel <jensseidel_at_users.sf.net>
Date: Tue, 21 Oct 2008 17:48:03 +0200

Hi,

let me add a note that I generally support translatable messages and
this is also true for error messages. But if there is really no
(real) possibility to see such an message it is just wasted time to
translate it.

Nevertheless the intention should be to also display a proper localized
but more general error message if a very rare event happened (such as
a database corruption). I'm not sure whether this happens currently
or whether the user is confused with a very technical message.

So instead of just printing

"Value kjadfk72 in structure lahflh2 has value 27468 but not 27826 or 262"

something like

"An internal error occurred:
 Either your repository or filesystem is corrupted or you found a bug.
 If you suspect a bug, please send us the following error message:
 "Value kjadfk72 ..."
"

would be great. I nevertheless didn't address this with this patch.

On Tue, Oct 21, 2008 at 04:16:10PM +0200, Neels J. Hofmeyr wrote:
> Jens Seidel wrote:
> > On Tue, Oct 21, 2008 at 01:28:05AM -0700, Greg Stein wrote:
> >> Is there a way to mark the strings as "We made a conscious decision to
> >> not translate these" ? ... I fear that in a year or so, somebody will
> >> come along, notice they done have _() around them, and *add* it back.
> >
> > Of course! Just invent a new unused macro similar to _() and mark the
> > text with it. Maybe I_() for internal or U_() for unused?
>
> Nice idea!
> U_() for "untranslatable"? ;)

OK, let's use U_().

> Jens, how about posting a patch for these things? It does take kind of
> longish at first, but all the work you do then doesn't need to be taken over
> by others, and they don't need to go search for stuff as you already did.
 
OK, I attached one. I don't like dealing with log messages but here is a
attempt:

[[[
Mark messages not useful for translation with U_(). This avoids that a
gettext call is later added accidentally again.

* subversion/svn_private_config.hw
  configure.ac:
  Define a new macro U_() to mark untranslatable strings similar to _().

* subversion/svn/tree-conflicts.c
  (svn_cl__append_human_readable_tree_conflict_description)
  subversion/libsvn_wc/tree_conflicts.c
  (svn_wc__write_tree_conflicts_to_entry):
  Use U_() for two strings with removed _() wrapper in r33792.

* www/hacking.html
  notes/l10n-problems: Document U_().
]]]

If you don't like it, please, please don't bother me and either improve
it later yourself or provide a proper text.

> You probably know this already...

Yep.

> of your working copy. -- but wait, you're on windows, right? :/

Of course NOT (it doesn't have a proper license and even in ReactOS
I miss the Unix flair :-)).

PS: Don't forget to call ./autogen.sh again. Don't know why autotools
are not started by default after touching configure.ac. Argh, now I see,
it's a autoconf project but not a automake one ... OK, this explains it.

Jens

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-10-21 17:49:07 CEST

This is an archived mail posted to the Subversion Dev mailing list.