[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #3292: 'svnlook diff' regression: doesn't print added dirs

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 21 Oct 2008 17:22:28 +0200 (Jerusalem Standard Time)

Neels J Hofmeyr wrote on Tue, 21 Oct 2008 at 16:57 +0200:
> Hi Frederic,
>
> thanks a lot for your patch,

+1

> but please do look up the Subversion Hacking Guide on log messages:
>
> http://svn.collab.net/repos/svn/trunk/www/hacking.html#log-messages
>
> It makes committers' life much easier if everyone sending patches sends
> well-formed log messages. It requires deep insight into the patch, and a log
> message which provides that is very helpful.
>

Can we focus on the contents of the patch rather on the (single) formal
deficiency in the submission? It's a trivial-looking one line patch,
after all.

I'm more concerned about having a regression test for the bug than for the
(correctable at commit time) briefness of the log message.

Daniel

> If you don't mind, please improve your log message. ;)
>
> ~Neels
>
> Frederic Melot wrote:
> > Hello,
> >
> > here is a patch submission for issue #3292.
> >
> > Best regards,
> > Frédéric Melot
> >
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-21 17:22:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.