[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Some problematic strings in Subversion

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 21 Oct 2008 08:14:20 +0100

On Tue, Oct 21, 2008 at 03:52:10AM +0200, Neels J Hofmeyr wrote:
> >> Index: subversion/svn/notify.c
> >> ===================================================================
> >> --- subversion/svn/notify.c (Revision 33718)
> >> +++ subversion/svn/notify.c (Arbeitskopie)
> >> @@ -83,7 +83,7 @@
> >>
> >> if (nb->skipped_paths > 0)
> >> SVN_ERR(svn_cmdline_printf
> >> - (pool,_(" Skipped paths: %u\n"), nb->skipped_paths));
> >> + (pool,_(" Skipped paths: %u\n"), nb->skipped_paths));
> >
> > Nice catch! But it should be:
> >
> > - (pool,_(" Skipped paths: %u\n"), skipped_paths));
> > + (pool, _(" Skipped paths: %u\n"), skipped_paths));
>
> Uh what? s/nb->// ? And the indentation?
> >
> > Committed in r33784.
>
> $ svn diff -c 33784
> Index: subversion/svn/notify.c
> ===================================================================
> --- subversion/svn/notify.c (revision 33783)
> +++ subversion/svn/notify.c (revision 33784)
> @@ -107,7 +107,7 @@
>
> if (skipped_paths > 0)
> SVN_ERR(svn_cmdline_printf
> - (pool,_(" Skipped paths: %u\n"), skipped_paths));
> + (pool, _(" Skipped paths: %u\n"), skipped_paths));
>
> return SVN_NO_ERROR;
> }
>
>
> Well, everything seems to be in order after all.

Jens made his diff against an old revision.
The nb-> was dropped in a later commit.
 
> >> - "Dump the contents of filesystem to stdout in a 'dumpfile'\n"
> >> + "Dump the contents of the repository to stdout in a 'dumpfile'\n"
> >
> > 'svnadmin dump' really *only* dumps the filesystem! No config files,
> > no locks, no hook scripts, etc.
> >
> > I'd strongly suggest we really make it dump the whole repository before
> > changing this message.
>
> Filed issue #3299.
> http://subversion.tigris.org/issues/show_bug.cgi?id=3299

Thanks!
(Small nit: It was Michael Diers who originally suggested this though,
not me :)

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-21 09:14:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.