[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r33790 - trunk/subversion/tests/cmdline

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 21 Oct 2008 02:08:45 +0200

> > > + def get_wc_uuid(wc_dir):
> > > + "Return the UUID of the working copy at WC_DIR."
> >
> > Plagiarist. :-) This function is word-for-word identical to the
> > function I wrote in update_uuid_changed() in update_tests.py (there it
> > is called 'wc_uuid'). Can't we get rid of the code duplication?
> > (Perhaps even parse the 'svn info' output into a dict in the process?)
>
> Please help fixing it ;-)
>
> I just needed a way to fix the test after fixing the cause of info test 3
> and copying this function was the easy way to fix the build.
>
> These merge tests depend on the exact output of subversion commands,
> breaking on every tiny detail, while they should only test the real
> functionality.
>

I'll look into it. (No other merge_tests run 'svn info', however.) In
addition to this function, verify_lines() is also duplicated.

Daniel

> Bert

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-21 02:08:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.