[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

No environment variables (was: svn commit: r33767 - trunk/subversion/libsvn_ra)

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 19 Oct 2008 19:56:10 -0700

Woah...

I don't support this change. One of svn's design points when we first
started was "no environment variables". Yes, we have some, but each
was considered carefully before adding. The reason to avoid
environment variables is that they subtly alter the operation of the
software. If you have/don't-have the variable defined, then the code
acts quite differently. Our goal was to make Subversion's operation as
obvious and straight-forward as possible, and one of the ways to that
was to minimize the use of environment variables.

In this case, a user can set a configuration value, so there is no
need for an environment variable.

-g

On Sun, Oct 19, 2008 at 6:31 PM, <arfrever_at_tigris.org> wrote:
> Author: arfrever
> Date: Sun Oct 19 18:31:27 2008
> New Revision: 33767
>
> Log:
> Support SVN_HTTP_LIBRARY environment variable for specifying which HTTP library
> should be used.
>
> * subversion/libsvn_ra/ra_loader.c
> (svn_ra_open3): Use SVN_HTTP_LIBRARY environment variable if it exists.
> Otherwise use http-library configuration option.
>
> Modified:
> trunk/subversion/libsvn_ra/ra_loader.c
>
> Modified: trunk/subversion/libsvn_ra/ra_loader.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra/ra_loader.c?pathrev=33767&r1=33766&r2=33767
> ==============================================================================
> --- trunk/subversion/libsvn_ra/ra_loader.c Sun Oct 19 15:18:42 2008 (r33766)
> +++ trunk/subversion/libsvn_ra/ra_loader.c Sun Oct 19 18:31:27 2008 (r33767)
> @@ -19,6 +19,8 @@
> /* ==================================================================== */
>
> /*** Includes. ***/
> +#include <stdlib.h>
> +
> #define APR_WANT_STRFUNC
> #include <apr_want.h>
>
> @@ -508,11 +510,12 @@ svn_error_t *svn_ra_open3(svn_ra_session
> }
> #ifdef CHOOSABLE_DAV_MODULE
> /* Now, which DAV-based RA method do we want to use today? */
> - http_library
> - = svn_config_get_server_setting(servers,
> - server_group, /* NULL is OK */
> - SVN_CONFIG_OPTION_HTTP_LIBRARY,
> - "neon");
> + if (! (http_library = getenv("SVN_HTTP_LIBRARY")))
> + http_library
> + = svn_config_get_server_setting(servers,
> + server_group, /* NULL is OK */
> + SVN_CONFIG_OPTION_HTTP_LIBRARY,
> + "neon");
>
> if (strcmp(http_library, "neon") != 0 &&
> strcmp(http_library, "serf") != 0)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: svn-help_at_subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-20 04:56:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.