[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r33750 - trunk/subversion/libsvn_wc

From: Bert Huijben <bert_at_vmoo.com>
Date: Sun, 19 Oct 2008 17:59:04 +0200

> -----Original Message-----
> From: Greg Stein [mailto:gstein_at_gmail.com]
> Sent: Sunday, October 19, 2008 3:51 PM
> To: dev_at_subversion.tigris.org; rhuijben_at_tigris.org
> Subject: Re: svn commit: r33750 - trunk/subversion/libsvn_wc
>
> Good catch! Thanks for the tweak.

        Greg,

This fix and my follow up don't seem to fix the problem that some other code
depends on the global static struct is writable.

Can you take a look at this?

The crash Sander reported is that Visual C++ put the static const structure
in a read only memory segment; the other compilers/OSs seem to allow writing
to it. I don't think marking the structure non-const is a real solution, as
this will give multithreading issues.

Thanks,

        Bert

>
> On Sun, Oct 19, 2008 at 5:53 AM, <rhuijben_at_tigris.org> wrote:
> > Author: rhuijben
> > Date: Sun Oct 19 05:53:39 2008
> > New Revision: 33750
> >
> > Log:
> > * subversion/libsvn_wc/lock.c
> > Following up on r33676, skip writing to the now read only missing
> instance.
> > This should fix several testcases on the Windows buildbot.
> >
> > Modified:
> > trunk/subversion/libsvn_wc/lock.c
> >
> > Modified: trunk/subversion/libsvn_wc/lock.c
> > URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_wc/lock.c?path
> rev=33750&r1=33749&r2=33750
> >
> =======================================================================
> =======
> > --- trunk/subversion/libsvn_wc/lock.c Sat Oct 18 18:59:17 2008
> (r33749)
> > +++ trunk/subversion/libsvn_wc/lock.c Sun Oct 19 05:53:39 2008
> (r33750)
> > @@ -758,6 +758,13 @@ do_open(svn_wc_adm_access_t **adm_access
> > apr_hash_this(hi, &key, NULL, &val);
> > entry_path = key;
> > entry_access = val;
> > +
> > + if (entry_access == &missing)
> > + {
> > + /* Entry is missing or obstructed; see above */
> > + continue; /* Skip or we will write read only
> memory */
> > + }
> > +
> > apr_hash_set(shared->set, entry_path,
> APR_HASH_KEY_STRING,
> > entry_access);
> > entry_access->shared = shared;
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
> > For additional commands, e-mail: svn-help_at_subversion.tigris.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-19 17:59:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.