[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33688 - branches/fsfs-pack/subversion/libsvn_fs_fs

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 16 Oct 2008 03:31:47 -0700

On Thu, Oct 16, 2008 at 2:41 AM, <hwright_at_tigris.org> wrote:
>...
> +++ branches/fsfs-pack/subversion/libsvn_fs_fs/fs_fs.c Thu Oct 16 02:41:58 2008 (r33688)
>...
> +packer_func(void *baton,
> + const char *path,
> + const apr_finfo_t *finfo,
> + apr_pool_t *pool)
> +{
>...
> + /* Copy all the bits from the rev file to the end of the pack file. */
> + SVN_ERR(svn_stream_open_readonly(&rev_stream, path, pool, pool));
> + SVN_ERR(svn_stream_copy2(rev_stream, pb->pack_stream, NULL, NULL, pool));
> + svn_stream_close(rev_stream);
> +
> + return SVN_NO_ERROR;

svn_stream_close() can return an error. So either toss it with clear()
or return it as the result.

>...

Cheers,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-16 12:32:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.