[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fs-rep-sharing branch

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Tue, 14 Oct 2008 16:56:27 +0200

Hyrum K. Wright wrote:
> The fs-rep-sharing branch is functionally complete, and I'd like to get the
> branch merged to trunk soon. These are the stats for various copies of of our
> repository for the different branch/backend combinations.
...
> The remaining issue is the failing blame tests. Blame tests 10 and 11, which
> test 'blame -g', both fail for both backends. Before the recent commits to add
> rep-sharing to fsfs, the tests only failed for bdb. I'm slightly puzzled here
> because 'blame -g' should be FS-agnostic. If anybody has some insight, I
> welcome it.

Just a note:
cmpilato and I discussed the failing blame tests today, and we tracked it down
to svn_fs_contents_changed(). Because the representations are the same,
svn_fs_contents_changed() now returns FALSE, instead of TRUE, in cases where the
two nodes being compared result in a empty delta. This probably impacts more
than just 'blame -g'.

It turns out that svn_fs_contents_changes() is being used to answer multiple
questions, which until now have been answerable in the same way. We'll have to
take a look at whether we fix the existing API, or provide another which allows
us to differentiate these questions.

-Hyrum

Received on 2008-10-14 16:56:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.