Re: svn commit: r33612 - in trunk: . subversion/tests/libsvn_delta

Greg Stein wrote on Mon, 13 Oct 2008 at 07:00 -0700:
> On Mon, Oct 13, 2008 at 6:42 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> >...
> >> * subversion/tests/libsvn_delta:
> >> (svn:ignore): ignore the new window-test executable
> >
> > (I prefer to see these with uppercase first letter.)
>
> "these" refers to ... what?
>

The sentences after colons in log messages.

> >...
> >> + /* Note: put these in data segment, not the stack */
> >
> > Why?
> >
> >> + static char source[109001];
> >> + static char target[109001];
>
> 220k on the stack is a bit much, I think. The values are basically
> const, but hard to initialize at compile time. I'll expand the docco
> just a bit.
>

*nod*

I also received off-list responses that indicated other considerations
(such as caching); thanks to all.

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-13 16:21:58 CEST