[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r33602 - trunk/subversion/libsvn_client

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Sun, 12 Oct 2008 16:08:06 +0100

Bert Huijben wrote:
> > > Implement this by passing a svn_boolean_t* use_sleep to all function
> > that
> > > require a sleep for timestamp integrity. The calling function will
> > then call
> > > svn_sleep_for_timestamps() when use_sleep is set to TRUE.
> >
> > In the implementation, notice that many of our functions have far too
> > many arguments for a human mind to keep track of already. Instead of
> > passing another argument, would it be better to put the "needs sleep"
> > variable in the merge command baton which appears to be already passed
> > around to the required places?
> >
> > (I see places where the baton is named "merge_options", and that name
> > would then want to be improved because it would no longer contain just
> > options, but that's not a problem.)
>
> Merge options and the baton are two completely different things. The
> merge_options parameter is an array of string parameters passed to the diff3
> tool.

Oops, sorry, I didn't look hard enough. Yes, "merge_options" is not the
baton. I meant the merge_cmd_baton_t. And I see that only some of the
functions take this baton.

> [...] (But this cleanup is unrelated to this
> performance work; there some other candidates for inclusion).

Sure, but any clean-up is valuable in this complex source file, and it's
easier and more likely to happen now than later. I'll commit the
attached patch when the test suite completes successfully if you've no
objection.

Thanks.
- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-10-12 17:08:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.