[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove platform visibility from Subversion auth functions (Was: Python bindings build seems broken)

From: Jeremy Whitlock <jcscoobyrs_at_gmail.com>
Date: Sat, 11 Oct 2008 12:21:55 -0600

>> Everything looks sound. It compiles because all of the stuff that is
>> public to all systems only reference structures and functions defined
>> in the Subversion headers.
>
> That's the point. The declarations of svn_auth_*keychain* were excluded
> by the (accidental) line:
>
> -#if defined(DARWIN) || defined(DOXYGEN) || defined(CTYPESGEN)
> +#if defined(DOXYGEN) || defined(CTYPESGEN)
>
> Hence my puzzlement.

Understood.

>> Yeah. I think I was being a little too paranoid. I was just saying
>> that if a NULL can be returned, should we check for it and the answer
>> is no if we know 100% that it can't be NULL and in our case, we can.
>> NULL only is returned if you call a function for another platform and
>> that can't happen in cmdline.c since we conditionally include calls to
>> those functions.
>>
>
> Yes.

Great. I have what I need to fix this up. I also have a box with
kwallet and gnome-keyring now so I should be able to make the
necessary changes and test against all but Windows. If I get
everything looking good with the next iteration, I'll commit. At
least the approach was sound and that was what I was looking for.
Thank you so much for working with me on this.

-- 
Take care,
Jeremy Whitlock
http://www.thoughtspark.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-11 20:22:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.