Re: Python bindings build seems broken

On Thu, Oct 9, 2008 at 1:00 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> What functions are considered here? The gnome/kde/kwallet functions are
> new in 1.6 so we can still tweak them without revving them.

Here is a list of specific functions that would need revving:

subversion/include/svn_auth.h:
  svn_auth_get_keychain_simple_provider
  svn_auth_get_keychain_ssl_client_cert_pw_provider
  svn_auth_get_windows_simple_provider
  svn_auth_get_windows_ssl_server_trust_provider

subversion/include/svn_client.h
  svn_client_get_windows_simple_provider (DEPRECATED)

Here is a list of gnome-keyring/kwallet functions that would need revving:

subversion/include/svn_auth.h:
  svn_auth_gnome_keyring_version
  svn_auth_get_gnome_keyring_simple_provider
  svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider
  svn_auth_kwallet_version
  svn_auth_get_kwallet_simple_provider
  svn_auth_get_kwallet_ssl_client_cert_pw_provider

The only other platform specific stuff I found was for Win32 but they
were not part of the public API. Here are the consumers of the above
functions:

subversion/bindings/javahl/native/SVNClient.cpp:
  get_auth_provider

subversion/libsvn_subr/cmdline.c:
  svn_cmdline_set_up_auth_baton

I think this is complete. Honestly, the consumers of the functions
above handle the inclusion of the platform specific stuff so that you
should never end up with platform code for another system built in
with your system's code. But...if we decide that we need to rev the
svn_auth.h and svn_client.h functions to return errors in the revved
version and abort in the deprecated version, we still at least need to
update the code in SVNClient.cpp and cmdline.c to handle the errors
even if there is no way to gracefully handle them so we do not end up
with a memory leak.

-- 
Take care,
Jeremy Whitlock
http://www.thoughtspark.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org