[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33576 - trunk/subversion/libsvn_ra_serf

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Thu, 9 Oct 2008 18:43:48 +0400

On Thu, Oct 9, 2008 at 6:21 PM, Greg Stein <gstein_at_gmail.com> wrote:
> On Thu, Oct 9, 2008 at 5:05 AM, <zhakov_at_tigris.org> wrote:
>>...
>> +++ trunk/subversion/libsvn_ra_serf/xml.c Thu Oct 9 05:05:46 2008 (r33576)
>>...
>> +void
>> +svn_ra_serf__add_open_tag_buckets(serf_bucket_t *agg_bucket,
>> + serf_bucket_alloc_t *bkt_alloc,
>> + const char *tag, ...)
>> +{
>>...
>> + tmp = SERF_BUCKET_SIMPLE_STRING("=\"", bkt_alloc);
>> + serf_bucket_aggregate_append(agg_bucket, tmp);
>> +
>> + tmp = SERF_BUCKET_SIMPLE_STRING(val, bkt_alloc);
>> + serf_bucket_aggregate_append(agg_bucket, tmp);
>> +
>> + tmp = SERF_BUCKET_SIMPLE_STRING("\"", bkt_alloc);
>> + serf_bucket_aggregate_append(agg_bucket, tmp);
>
> You can use SERF_BUCKET_SIMPLE_STRING_LEN() for 2 of the buckets above.
>
Good point! Fixed in r33578.

-- 
Ivan Zhakov
VisualSVN Team
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-09 16:44:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.