[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Python bindings build seems broken

From: Jeremy Whitlock <jcscoobyrs_at_gmail.com>
Date: Wed, 8 Oct 2008 22:41:10 -0600

> I've not thought fully through this, but if the function now returns an
> svn_error_t *, and that error goes unhandled (because callers weren't
> expecting one), that's a memory leak and, in certain debug modes, an abort()
> as a result of such, right?

That's what I'd think. Basically, revving will be more work because
the consuming functions will need to also be updated to do error
handling without any real benefit, unless is protocol/convention.
Instead, I think the easiest way would be to move the #ifdefs into the
functions instead of around the function declarations/definitions and
then abort when being used on the wrong operating system. Is this
alright or do we need to rev, which will also mean we need to update
the consuming functions? Since the functions aren't changing their
signature or in some way working differently, revving might not be
necessary. How would you'd gracefully recover from using a function
not designed for your OS anyways?

Take care,
Jeremy Whitlock
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-09 06:41:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.