[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33548 - in trunk/subversion: include libsvn_client libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 8 Oct 2008 18:17:32 -0700

Fixed in r33566. Sorry about that.

On Wed, Oct 8, 2008 at 1:21 PM, Bert Huijben <bert_at_vmoo.com> wrote:
>> -----Original Message-----
>> From: gstein_at_tigris.org [mailto:gstein_at_tigris.org]
>> Sent: woensdag 8 oktober 2008 16:35
>> To: svn_at_subversion.tigris.org
>> Subject: svn commit: r33548 - in trunk/subversion: include
>> libsvn_client libsvn_wc
>>
>> Author: gstein
>> Date: Wed Oct 8 07:34:53 2008
>> New Revision: 33548
>>
>> Log:
>> Various cleanups and simplifications.
>>
>> Of particular note was the ridiculous svn_client_commit_item_create()
>> that
>> created a *const* result, meaning that callers couldn't actually store
>> values into their newly-created item. Instead, they'd cast a const in
>> there on *every* invocation (didn't somebody see *all* those casts as
>> an
>> indication of a problem!?). Also tossed the error result -- our other
>> constructors don't do that, and there is no reasonable expectation for
>> an
>> error result in the future.
>>
>> This change also completely deprecates all of the
>> svn_wc_process_committed()
>> functions. They depend upon one part of the code dropping a file with a
>> specific name into a specific location, and then this code swings by
>> and
>> picks it up. The coupling means we have *very* little flexibility in
>> changing the implementation. We don't use this function any more, in
>> favor
>> of the commit queue functions, so these are now completely deprecated
>> with
>> the hope that the queue can solve the coupling problem. It is so bad
>> that
>> I've simply removed the documentation to discourage any possible use.
>>
>> * subversion/include/svn_wc.h:
>> (svn_wc_queue_committed2): new version of the function with a draft
>> set
>> of arguments. This function has not (yet) been implemented.
>
> Adding such unimplemented declarations to the header files breaks the Windows shared library builds.
>
> Our python script that extracts the prototypes doesn't understand this case and adds this method to the .def file with the public functions in the DLL.
>
>>>>>>
> libsvn_wc.def : error LNK2001: unresolved external symbol svn_wc_queue_committed2
> ..\..\..\Release\subversion\libsvn_wc\libsvn_wc-1.lib : fatal error LNK1120: 1 unresolved externals
> <<<<<
>
> Bert
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-09 03:18:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.