[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Python bindings build seems broken

From: Jeremy Whitlock <jcscoobyrs_at_gmail.com>
Date: Wed, 8 Oct 2008 16:04:28 -0600

>> Is this another option:
>>
>> 4. Don't have platform-specific visibility for APIs in Subversion at all.
>> Instead, move the #defines that toggle the availability down into the
>> functions/structures themselves so that on platforms where the
>> functionality is not available, a not-implemented error is thrown?
>>
> +1. I like that idea! That would make things much easier from a SWIG
> point of view.

While working on making this a reality, I realize that most of the
functions affected by this return void. One option would be to rev
the related functions, use abort() in the function being revved and
make the new function return an svn_error_t, which would use
SVN_ERR_ASSERT to return the error when being invoked on the wrong
platform. (This is suggested in another thread:
http://www.nabble.com/-PATCH--svn_dso_initialize-can-*silently*-fail-to-create-lock-td18777052.html)
 But is this necessary? Since the function signature isn't changing,
nor is the content being returned changing, do we need to go through
the revving process? In this scenario, either you can call the
function or you can't. Why should the consumers of these functions
have to care?

-- 
Take care,
Jeremy Whitlock
http://www.thoughtspark.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-09 00:04:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.