[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: cvs2svn test suite breakage caused by svn changes

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 07 Oct 2008 13:07:55 +0100

Michael Haggerty wrote:
> The cvs2svn test suite was partly broken by some upstream changes in
> svntest (r32463 and r32484), which in turn were made to support format
> changes in the output of "svn proplist".

The change was an output formatting change from this:

[[[
$ svn-1.5 proplist --verbose
Properties on '.':
  bzr:revision-id:v3-trunk0 : 20214
jelmer_at_samba.org-20071206202757-xopl18j270rt83ve
20235 jelmer_at_samba.org-20071209150938-eavv3u65qqwjjkzy
20236 jelmer_at_samba.org-20071209172359-x679msv2p5e5a4px
20244 jelmer_at_samba.org-20071209215808-36ku3dm56r11230a
20248 jelmer_at_samba.org-20071210031219-74vd608op3jvp2qe

  svn:ignore : ChangeLog*
Makefile
config.cache
]]]

to this:

[[[
$ svn proplist --verbose
Properties on '.':
  bzr:revision-id:v3-trunk0
    20214 jelmer_at_samba.org-20071206202757-xopl18j270rt83ve
    20235 jelmer_at_samba.org-20071209150938-eavv3u65qqwjjkzy
    20236 jelmer_at_samba.org-20071209172359-x679msv2p5e5a4px
    20244 jelmer_at_samba.org-20071209215808-36ku3dm56r11230a
    20248 jelmer_at_samba.org-20071210031219-74vd608op3jvp2qe

  svn:ignore
    ChangeLog*
    Makefile
    config.cache
]]]

And the test suite's parsing of "svn proplist" output was adjusted
accordingly.

> The cvs2svn test suite uses code from the SVN test suite via
> svn:externals. Up until now, we have always imported the HEAD revision
> of svntest rather than selecting a particular revision. Up until now,
> that has not caused any serious problems :-)
>
> This is an awkward situation because AFAICT the old version of svntest
> won't work with a new Subversion build and vice versa. Since the
> cvs2svn test suite doesn't know what SVN version the user has installed,
> it has to work with any version.

Right. Looking at just the lowest level, we could say that your parser
of "svn proplist -v" output has to be able to read either style. But
looking at a higher level, we could say that you probably don't care
about the "svn proplist -v" command as such, but just want some way to
verify the values of properties.

> >From a broader perspective, it seems to me that the changes to the "svn
> proplist" output could also break other tools. I haven't been following
> the mailing list, so I don't know to what extent these changes were debated.

Yes, this is an incompatible change in output. I proposed the change in
this email: <http://svn.haxx.se/dev/archive-2008-08/0351.shtml>. The
incompatibility is, I think, outweighed by the improvement in
readability (given that the previous format was not robustly
machine-parsable anyway).

> If these changes were indeed intentional, I suppose that our only
> alternative would be to write a parser that can handle either form of
> the output (or switch to parsing the XML output or using the SVN
> bindings directly). Any other suggestions are welcome.

Yes, all of those are good. Sorry that it's a bit of work to adapt in
any of those ways.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-07 14:08:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.