[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: explaining inexplicable delay in svn diff

From: Bert Huijben <bert_at_vmoo.com>
Date: Sun, 5 Oct 2008 23:38:47 +0200

2008/9/25 Dirck Blaskey <listtarget2_at_danbala.com>:
> Recently upgraded to svn client 1.5.2, and all of a sudden simple diff
> commands take 12+ seconds.
> Using sysinternals processmonitor, it looks like svn is trying to create a
> file "tmp" in the TEMP folder;
> in my case (for some reason) there was already a folder called "tmp" in the
> TEMP folder, so
> svn burns about 12 seconds trying again repeatedly, until it moves on and
> tries tmp.2.
> If there is a file called "tmp" instead of a folder, it gets a name
> collision and moves on to tmp.2.
> Maybe you could check for the "IS DIRECTORY" result from CreateFile and not
> sit and spin.

I just applied a patch on this in r33464. This patch handles the case
where there is a collision on creating a unique filename. It will now
retry with the next name instead of delaying and retrying with the
same filename.

(The original implementation handled the directory exists condition as
non fatal error after 100 retries like your test showed).


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-05 23:39:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.