[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33396 - trunk/subversion/tests/libsvn_subr

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Sun, 05 Oct 2008 14:24:13 +0200

Daniel Shahaf wrote:
> lgo_at_tigris.org wrote on Thu, 2 Oct 2008 at 07:57 -0700:
>> Author: lgo
>> Date: Thu Oct 2 07:57:22 2008
>> New Revision: 33396
>>
>> Log:
>> Manually merged the remaining part of r33211 from the windows_dirents branch
>> to trunk.
>>
>
> ...which finishes the windows_dirents work. Thanks!
>
>> * subversion/tests/libsvn_subr/dirent_uri-test.c
>> (svn_dirent_is_absolute): Add some testcases.
> ^
> s/absolute/ancestor/
>
> But more importantly, r33211 also made copy_tests 74 pass on Windows.
> (The test is XFail on trunk, but passes on the branch. My fault for not
> making this clearer at the time I committed the fix.) I think the
> proper fix now is just:
>
> Index: subversion/libsvn_wc/copy.c
> ===================================================================
> --- subversion/libsvn_wc/copy.c (revision 33373)
> +++ subversion/libsvn_wc/copy.c (working copy)
> @@ -334,8 +334,8 @@ get_copyfrom_url_rev_via_parent(const char *src_pa
>
> /* Don't look for parent_path in src_access if it can't be
> there... */
> - if (svn_path_is_ancestor(svn_wc_adm_access_path(src_access),
> - parent_path))
> + if (svn_dirent_is_ancestor(svn_wc_adm_access_path(src_access),
> + parent_path))
> {
> SVN_ERR(svn_wc_adm_retrieve(&parent_access, src_access,
> parent_path, pool));
>
> but I don't have time to look further now. (I'll commit it myself in a
> few days, if I'm not beaten to it.)

Right. I wanted to ask you what that change was for, couldn't really
find it.

FYI, I'm currently creating all svn_dirent and svn_uri functions and
once that API is finished I'll start to migrate libsvn_wc,
libsvn_client, the ra layers one by one. Just want to make sure first
that the new API is correct before committing to it in 1.6.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-05 17:47:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.