[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33417 - in trunk/subversion: libsvn_wc tests/cmdline

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 3 Oct 2008 23:15:45 -0700

In the past, we've discussed "what should be allowed in a path name?"
and leaned a bit against "non-portable" characters. As i recall, at
least.

I think it would be totally fine to have a somewhat-restricted set of
pathname characters in the svn:externals. It is such an edge case to
have them in the first place, and then to put them into externals? ...
eesh.

I say: crimp down hard, and loosen up if somebody cries about it.

Cheers,
-g

On Fri, Oct 3, 2008 at 11:02 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> Philip Martin wrote:
>> Philip Martin <philip_at_codematters.co.uk> writes:
>>
>>> ordinary non-escape character. In the past using an svn:externals
>>> like "a\b URL" would produce a directory called "a\b" (that's a
>>> 3-character name) while a quick test indicates that it now appears to
>>> create a directory called "ab". To get "a\b" the svn:externals needs
>>> to be changed to "a\\b URL". I don't know if anyone is using such
>>> names in svn:externals, and I don't think they would not work on
>>> Windows, but change could break existing working copies and there
>>
>> Typo: I meant to write "I don't think they would work on Windows" but
>> it now occurs to me that it might create a directory "b" in a
>> directory "a". Perhaps somebody with a Windows machine could try it?
>
> Yes, using a local directory "a\b" in Windows causes Subversion to create
> directories "a" and "a\b", with the "a\b" as the external working copy.
>
> By way of a solution, I was *going* to suggest that '\' be *only* allowed to
> escape the quotation mark character. That would mean recognizing as magical
> only the sequence '\"'. But since you can't have a quotation mark in the
> name of a directory on Windows (and it's highly unlikely that someone would
> want to have such in Unix, either) we can reasonably assume that for a
> sequence like 'foo\"bar' the user couldn't really have meant that he/she
> wanted to flesh out some external in some subdir named '"bar'. But then, if
> we've gotten as far as to assume that users don't want quotation marks in
> their path names, why would we need an escape mechanism for the quotation
> mark at all? :-\
>
> --
> C. Michael Pilato <cmpilato_at_collab.net>
> CollabNet <> www.collab.net <> Distributed Development On Demand
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-04 08:15:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.