[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33404 - branches/fs-rep-sharing/subversion/libsvn_fs_fs

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 2 Oct 2008 13:36:43 -0700

On Thu, Oct 2, 2008 at 11:01 AM, <hwright_at_tigris.org> wrote:
>...
> +++ branches/fs-rep-sharing/subversion/libsvn_fs_fs/rep-cache.c Thu Oct 2 11:01:34 2008 (r33404)
>...
> + SVN_ERR(svn_sqlite__prepare(&stmt, ffd->rep_cache,
> + "select revision, offset, size, expanded_size from rep_cache "
> + "where hash = ?", pool));

In all strings where a substitution occurs, I much prefer the :NNN
form. With that, it makes it possible to rearrange the format string
without worrying about the supporting code.

This is not as important with SQL statements, but when you get into
I18N it becomes very important. Using the :NNN is a nice habit as a
result.

Cheers,
-g

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-02 22:36:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.