[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33350 - trunk/subversion/libsvn_repos

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 01 Oct 2008 09:43:37 -0500

Greg Stein wrote:
> On Mon, Sep 29, 2008 at 10:58 AM, <hwright_at_tigris.org> wrote:
>> ...
>
>> +++ trunk/subversion/libsvn_repos/load.c Mon Sep 29 10:58:09 2008 (r33350)
>> ...
>> +static svn_repos_parser_fns_t *
>> +fns_from_fns2(const svn_repos_parse_fns2_t *fns2,
>> + apr_pool_t *pool)
>
> Why this function? It appears there is just one caller, so why not
> simply do this inline?

In this instance, I was just following the model of the fns2_from_fns()
function, which also is only called once. The compile will do the inlining for
us, and I think that the functions provide useful abstractions, so I'm inclined
to leave it as is. (Though if others want to change it, that's fine by me.)

-Hyrum

Received on 2008-10-01 16:43:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.