[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: relative externals fail with spaces

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 30 Sep 2008 21:40:33 -0400

Stefan Küng <tortoisesvn_at_gmail.com> writes:
> I'm wondering: this change is in libsvn_client, i.e., it's independent
> of the ra layer. But the issue only shows for http(s), not for file or
> svn. So what are ra_svn and ra_local doing differently?
> I'm not familiar with that part of the svn code, but couldn't this lead
> to double-escaping of urls if ra_svn/ra_local already do this themselves?

What's going on is that file:// and svn:// do looser URL-parsing than
http://. The error came from libsvn_ra_neon/session.c:parse_url(); in
fact, it's possible that with ra_serf, there would have been no error or
a different error. So file:// and svn:// weren't already doing the
escaping themselves. The difference is just that they could handle a
URL with spaces in it :-).

(My patch passed 'make check' over all RA layers, and I checked svn://
in GDB too -- the URL is not double-escaped there.)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-10-01 03:40:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.