[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Merging the ctypes python bindings to trunk

From: David James <james82_at_gmail.com>
Date: Mon, 29 Sep 2008 14:51:20 -0700

On Sun, Sep 21, 2008 at 3:25 PM, Arfrever Frehtes Taifersar Arahesis
<arfrever.fta_at_gmail.com> wrote:
> I would like to suggest to use `svn mv` and to place the ctypes python
> bindings in ^/trunk/subversion/bindings/ctypes-python directory. The name
> of the 'bindings' directory informs that its subdirectories contains
> Subversion bindings.

Good suggestion. I've done just that in r33355 when I merged ctypesgen to trunk.

On Tue, Sep 23, 2008 at 12:13 AM, Eric Gillespie <epg_at_pretzelnet.org> wrote:
> "David James" <james82_at_gmail.com> writes:
>
>> Index: csvn/core/__init__.py
>> ===================================================================
>> --- csvn/core/__init__.py (revision 33199)
>> +++ csvn/core/__init__.py (working copy)
>> @@ -102,3 +102,36 @@
>> # Mark pool as valid
>> self._is_valid = lambda: 1
>>
>> +
>> +if sys.platform == "win32":
>> +
>> + # Special case: Make sure that Windows-specific functions are available
>> + # on Windows, even if the headers were generated on a different platform
>
> This is OK, I guess. If more platform-specific APIs are added,
> they won't be bound until someone writing a Python app wants to
> use it :(. This is the situation with swig-py, which I hoped
> would go away. If that situation persists on a tiny subset of
> the svn API, that's still a giant improvement.
>
>> + if hasattr(_libs['svn_client-1'],
>
> I think all the svn_client forms of these are deprecated; it's
> probably better to leave them out.

Good points. To help ensure that platform-specific APIs show up
automatically, I've made two changes:
  1. I taught ctypesgen to wrap all APIs, even if the API is not
present in the libraries on your platform.
  2. I updated the Subversion headers to include platform-specific
functions if 'CTYPESGEN' is defined.

If people add new platform-specific functions, they should follow our
example and let ctypesgen see the functions by including the functions
in the headers if CTYPESGEN is defined. This way, it won't be
necessary to manually wrap any new APIs.

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-29 23:51:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.