[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: propchange - r30546 - svn:log

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Thu, 25 Sep 2008 10:46:14 -0400

"Bert Huijben" <b.huijben_at_competence.biz> writes:
>> > -Found by: Bert Huijben (bert_at_vmoo.com)
>> > \ No newline at end of file
>> > +Found by: Bert Huijben <b.huijben_at_competence.biz>
>>
>> For committers, we usually just use the username as listed in
>> COMMITTERS and the
>> contribulyzer with automagically match everything up.
>
> The magic didn't work for this commit ;).
> (All my other patches in the contribulyzer were ok).
>
> See http://www.red-bean.com/svnproject/contribulyzer/detail/berthuijben(bert@vmoo.com).html
>
> I think the problem was caused by the parens in this commit.

No, Hyrum meant you should just write:

   Found by: rhuijben

Of course, it should work the same if you write:

   Found by: Bert Huijben <b.huijben_at_competence.biz>

...since that's the expansion of "rhuijben" in COMMITTERS. But when you
use some other email address, Contribulyzer just thinks it's a different
person. And you're right, it can't handle parens around the email
address, as far as I know.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-25 16:46:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.