[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

calculate_remaining_ranges(child->path == NULL)

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 24 Sep 2008 17:39:28 +0100

I noticed that calculate_remaining_ranges()'s doc string implies its
"child" argument's "path" field is always used:

> /* Helper for do_file_merge and do_directory_merge (by way of
> populate_remaining_ranges() for the latter).
>
> Determine what portions of URL1_at_REVISION1 -> URL2_at_REVISION2 have already
> been merged to CHILD->PATH and populate CHILD->REMAINING_RANGES with the
> ranges that still need merging.
> [...]

... but do_file_merge() calls it with the "child" argument being a
structure freshly created with apr_pcalloc(), so its "path" field is
null.

Is there some special case missing from the doc string?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-24 18:39:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.