Re: Merging the ctypes python bindings to trunk

"David James" <james82_at_gmail.com> writes:

> Index: csvn/core/__init__.py
> ===================================================================
> --- csvn/core/__init__.py (revision 33199)
> +++ csvn/core/__init__.py (working copy)
> @@ -102,3 +102,36 @@
> # Mark pool as valid
> self._is_valid = lambda: 1
>
> +
> +if sys.platform == "win32":
> +
> + # Special case: Make sure that Windows-specific functions are available
> + # on Windows, even if the headers were generated on a different platform

This is OK, I guess. If more platform-specific APIs are added,
they won't be bound until someone writing a Python app wants to
use it :(. This is the situation with swig-py, which I hoped
would go away. If that situation persists on a tiny subset of
the svn API, that's still a giant improvement.

> + if hasattr(_libs['svn_client-1'],

I think all the svn_client forms of these are deprecated; it's
probably better to leave them out.

Thanks.

-- 
Eric Gillespie <*> epg_at_pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org