[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] [PATCH] Move declarations of svn_auth_get_(gnome_keyring|kwallet)_* to svn_auth.h

From: Jeremy Whitlock <jcscoobyrs_at_gmail.com>
Date: Mon, 22 Sep 2008 16:38:47 -0600

> I would like to suggest to move declarations of svn_auth_get_(gnome_keyring|kwallet)_*
> from svn_auth_dso.h to svn_auth.h.
>
> [[[
> Move declarations of svn_auth_get_(gnome_keyring|kwallet)_* to svn_auth.h.
>
> * subversion/include/svn_auth.h
> (svn_auth_get_gnome_keyring_simple_provider,
> svn_auth_get_gnome_keyring_ssl_client_cert_pw_provider,
> svn_auth_get_kwallet_simple_provider,
> svn_auth_get_kwallet_ssl_client_cert_pw_provider): Move to here from
> svn_auth_dso.h.
>
> * subversion/include/svn_auth_dso.h: Delete.
>
> * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c:
> * subversion/libsvn_auth_kwallet/kwallet.cpp: Don't include "svn_auth_dso.h".
>
> * build/generator/extractor.py
> (_filter_names): Append svn_auth_get_*_provider.
> ]]]
>
> --
> Arfrever Frehtes Taifersar Arahesis
>

I like this idea since it would be more inline with what was
previously in svn_auth.h for Mac OSX's Keychain support. I also like
the fact that this would mean no auth-specific shared library when
building in support for kwallet or gnome-keyring. +1

-- 
Take care,
Jeremy Whitlock
http://www.thoughtspark.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-23 00:38:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.