Re: svn commit: r33201 - in trunk/subversion: libsvn_wc tests/cmdline

Karl Fogel wrote on Sat, 20 Sep 2008 at 17:21 -0400:
> Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:
> >> To clarify: do you know of a way to make this strcmp() return 0,
> >
> > without manually corrupting the wc; just using svn commands. In other
> > words, would this 'if' ever be entered to on a non-corrupt wc?
>
> Yes, I think so. I didn't bother to test this, but:
>
> $ cd greek-tree-working-copy
> $ svn cp A A2
> $ cd A/B
> $ chroot . svn mv lambda blah
>
> But I prefer to think of it as an abstract question: "Can we count on
> svn_path_dirname() never returning its input unchanged?"
>
> The answer is "no"; therefore we must test for that situation if it
> would lead to an infinite loop.
>

I see: svn_path_dirname("/") == "/" is the case you're protecting
against. Fine, I can think of a few ways to get it.

> -Karl

Shouldn't we backport this?

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-20 23:56:14 CEST