[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33178 - in trunk/subversion: libsvn_client libsvn_subr

From: Blair Zajac <blair_at_orcaware.com>
Date: Fri, 19 Sep 2008 06:47:41 -0700

rhuijben_at_tigris.org wrote:
> Author: rhuijben
> Date: Fri Sep 19 01:41:23 2008
> New Revision: 33178
>
> Log:
> Avoid calling apr_status with APR_FINFO_PROT | APR_FINFO_OWNER on Windows, as
> this call is 'incredibly expensive, but accurate' and the result is ignored
> anyway.

These comments should be in the code itself since it's very rare to see #ifdef
WIN32 in libsvn_client code and people will wonder why it's special cased.

Also, if you have #ifndef ... #else ... #endif, use #ifdef instead.

Regards,
Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-19 15:48:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.