[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: propchange - r33150 - svn:log

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 18 Sep 2008 10:07:32 -0500

Thanks, but I could change it myself if I was concerned. I'm worried
about the pattern/trend rather than this specific case. Changing a log
message occurred maybe once a month when I used to contribute. Now, I
see a dozen a week. And many for what I would call "pedantic" reasons
rather than helpful. CMike points out that log message fixed can be
good for all future contributors/readers, but I think the rigidity is
troublesome (as Lubbe noted).

-g

On Sep 18, 2008, at 9:16, Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com
> wrote:

> 2008-09-18 14:46:43 Greg Stein napisał(a):
>> Why this change? Since the last time I spent working on Subversion,
>> now that I'm back, I'm finding a crazy amount of attention spent to
>> the log messages. Adding periods, correcting typos, adjusting
>> indentation, etc. Shoot, I saw somebody correct a log from rev 1400
>> or
>> so just a week ago.
>>
>> What is up with that? Where is the flexibility, and why so much
>> attention?
>>
>> And with this change to my log message, you remove *MY* character,
>> and
>> turn it into some bland message devoid of my personality. I *like*
>> shortening to "tho". I don't like you removing my personality from my
>> log messages. Are you also going to edit out a joke or quip that I
>> might put in there, in the future? Are all our log messages destined
>> for some bland, grey goo?
>
> I'm not native English speaker and I thought that "tho" is incorrect.
> I can revert this propchange, if you want.
>
>> On Sep 18, 2008, at 7:17, arfrever_at_tigris.org wrote:
>>
>>> Author: arfrever
>>> Revision: 33150
>>> Property Name: svn:log
>>> Action: modified
>>>
>>> Property diff:
>>> --- old property value
>>> +++ new property value
>>> @@ -6,7 +6,7 @@ Bring the branch up to date with respect
>>> An extra change snuck into this commit:
>>>
>>> Updated some comments on string/array lifetimes, and moved an array
>>> into
>>> -an iteration pool (tho its values are longer-lived).
>>> +an iteration pool (though its values are longer-lived).
>>>
>>> * subversion/libsvn_wc/experiment.c:
>>> (generic_walker): dirkeys can be in the iteration pool. the string
>>>
>>> ---
>>> ------------------------------------------------------------------
>>> To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
>>> For additional commands, e-mail: svn-help_at_subversion.tigris.org
>>>
>
> --
> Arfrever Frehtes Taifersar Arahesis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-18 17:08:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.