Re: [PATCH v2] Issue #2748: non-UTF-8 filenames in the repository

> > @@ -324,6 +326,28 @@ default_warning_func(void *baton, svn_error_t *err
> > abort();
> > }
> >
> > +static svn_error_t *
> > +path_valid(const char *path, apr_pool_t *pool)
>
> Please add a doc-string.
>

It was in the header file, but then I made the function file-local and
forgot to move it here. Fixed.

> > + return svn_error_createf(SVN_ERR_FS_PATH_SYNTAX, NULL,
> > + _("Path '%s' contains '.' or '..' element"));
>
> You have to supply a 'path' argument to correspond to the '%s' !
>
> (Some compilers - at least GCC - ought to warn you of that, I think.)
>

Fixed.

> The rest looks good.
>
> - Julian
>

Great. Committed r33148.

Thanks,

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-17 23:44:11 CEST