Re: svn commit: r33126 - trunk/subversion/libsvn_wc

On Sep 17, 2008, at 5:52 AM, gstein_at_tigris.org wrote:

> Author: gstein
> Date: Wed Sep 17 05:52:35 2008
> New Revision: 33126
>
> Log:
> Add new API for opening many admin databases at once.
>
> * subversion/libsvn_wc/wc_db.h:
> (svn_wc__db_open_many): new function
>
> + * Results will be alloated in @a result_pool, and temporary
> allocations
> + * will be made in @a scratch_pool.
> + */
> +svn_error_t *
> +svn_wc__db_open_many(apr_hash_t **dbs,
> + const apr_array_header_t *paths,
> + svn_config_t *config,
> + apr_pool_t *result_pool,
> + apr_pool_t *scratch_pool);

Why not have svn_wc__db_open_many() create a subpool in result_pool
and then destroy it when it's done? It's rare for any svn API to take
two pool arguments.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-17 17:24:30 CEST