[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] Introducing svn_client_make_diff_args? (Was: RE: svn commit: r33116 - in branches/ignore-mergeinfo/subversion: include libsvn_client svn)

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 17 Sep 2008 15:33:44 +0100

Hyrum K. Wright wrote:
> Bert Huijben wrote:
> > Shouldn't we create some kind of context/args object that we can
> extend in future versions for methods that probably have yet another
> version in the next release?
> >
> > Adding boolean number 4 to a function doesn't make user code more
> understandable, and with a context/args struct with a constructor
> function we can just extend that structure in the next release without
> breaking the ABI.
>
> I thought about this same issue when extending the status API on the
> ignore-mergeinfo branch. I suspect there are several APIs we could do this too
> next time we rev them. If we identify those, we should put a note in their
> comments.
>
> Bert, could you write the patch (against the ignore-mergeinfo branch, of course)
> for this?

I think it would be sensible to do that on trunk. Although there's an
overlap, it's a logically independent change that can happen before or
after the ignore-mergeinfo changes.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-17 16:34:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.