Re: [PATCH] Issue #2748: non-UTF-8 filenames in the repository

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

> My original reason was that the current contract actively promises that
> it *won't* check validity:
>
> * ASSUMPTION: @a path is a valid UTF-8 string. This function does
> * not check UTF-8 validity.
>
>> Is it because the function may be fed input from existing repositories
>> which isn't valid UTF-8?
>>
>
> Well, yes, being nice to existing invalid filenames is a consideration.
>
> Another is that this function is used all over the code -- including by
> svn_wc_add3(), svn_fs_make_file(), and others. Changing the semantics
> in all these places may have unexpected side effects.

It sounds like it would be better to add calls to svn_utf__is_valid in
the places that need to check.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-17 16:13:00 CEST