[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #2748: non-UTF-8 filenames in the repository

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 17 Sep 2008 15:17:37 +0200

On Wed, Sep 17, 2008 at 03:42:21PM +0300, Daniel Shahaf wrote:
> Patch for issue #2748 ("clients can create non UTF-8 filenames in the
> repository"). It prevents non-UTF-8 paths from entering the repository,
> but it doesn't affect existing files in existing repositories, svnsync,
> or 'svnadmin load'.
>
> I'm running 'make check' now, and I'll commit later today or tomorrow if
> I don't hear anything.

Drive-by question:

I thought we always handle strings in UTF-8 internally.
So why not just make svn_path_check_valid check for UTF-8 by default?

Is it because the function may be fed input from existing repositories
which isn't valid UTF-8?

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-17 15:18:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.