[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 3257] New - perl 5.10.0 doesn't seem to alow opening in memory to a constant

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 15 Sep 2008 17:02:10 +0300 (Jerusalem Daylight Time)

Has this been committed?

In general, what is the status of the Perl bindings? I remember other
issues there -- e.g. [1] -- that haven't been addressed yet.

Daniel

[1] http://thread.gmane.org/gmane.comp.version-control.subversion.devel/99829/focus=102787

arekm_at_tigris.org wrote on Sun, 10 Aug 2008 at 09:23 -0000:
> http://subversion.tigris.org/issues/show_bug.cgi?id=3257
> Issue #|3257
....
>
> ------- Additional comments from arekm_at_tigris.org Sun Aug 10 02:23:37 -0700 2008 -------
> perl 5.10 doesn't seem to allow opening in memory to a constant
>
> ../../../../../subversion/bindings/swig/perl/native/t/6ra..............1/40
> Modification of a read-only value attempted at ../../../../../subversion/
> bindings/swig/perl/native/t/6ra.t line 225.
> error opening in-memory file to store Subversion update: Invalid argument
> at ../../../../../subversion/bindings/swig/perl/native/t/6ra.t line 225.
>
> Fix:
>
> --- ./subversion/bindings/swig/perl/native/t/6ra.t.org 2008-08-10
> 11:16:08.571581580 +0200
> +++ ./subversion/bindings/swig/perl/native/t/6ra.t 2008-08-10
> 11:18:55.423648224 +0200
> @@ -221,10 +221,12 @@
>
> sub apply_textdelta {
> my ($self, $baton, $base_checksum, $pool) = @_;
> - my $data = $baton->{data} = \'';
> + my $mem1;
> + my $mem2;
> + my $data = $baton->{data} = \$mem1;
> open my $out_fh, '>', $data
> or die "error opening in-memory file to store Subversion update: $!";
> - open my $in_fh, '<', \''
> + open my $in_fh, '<', \$mem2
> or die "error opening in-memory file for delta source: $!";
> return [ SVN::TxDelta::apply($in_fh, $out_fh, undef, "$baton", $pool) ];
> }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-15 16:02:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.