[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33043 - trunk/subversion/libsvn_client

From: Philip Martin <philip_at_codematters.co.uk>
Date: Sat, 13 Sep 2008 19:52:55 +0100

"Hyrum K. Wright" <hyrum_wright_at_mail.utexas.edu> writes:

> Philip Martin wrote:
>>
>> Looks like pointless code churn to me; every active branch is now
>> facing a massive merge. What is the gain?
>
> Aside from the slight performance gain, this also adds some consistency.
> Instead of making these changes piecemeal, usually along with unrelated changes
> in the same files, I thought it better to do an audit of the code and do them
> all at once.

I'd be surprised if the "performance gain" is measurable, even without
optimisation. Once you add optimisation any gain might well disapear
altogether, have you looked at the generated code? As for
consistency, I suppose you are making function return style (or
something else?) more consistent, but you are also reducing
consistency: most svn_xxx calls are wrapped in SVN_ERR and you are
introducing lots of exceptions.

It still looks like pointless code churn to me, I fail to see how the
new code is better or worse than the old code.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-13 20:54:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.