[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r32905 - trunk/subversion/include

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Fri, 05 Sep 2008 15:20:26 -0400

julianfoad_at_tigris.org writes:
> Log:
> Document whether constructors make deep or shallow copies of data passed to
> them by reference.
> * subversion/include/svn_fs.h
> (svn_fs_create_access): Document that it makes a deep copy of 'username',
> * subversion/include/svn_string.h
> Document that all string functions make deep copies of input strings.
> * subversion/include/svn_wc.h
> (svn_wc_create_notify, svn_wc_conflict_description_create_text,
> svn_wc_conflict_description_create_prop, svn_wc_create_conflict_result):
> Document that each of these makes a shallow copy of pointer arguments.

Sorry, I know I should have responded to your earlier request for
comment on this (but I already told you about my lost day looking for my
wireless modem, right?)

Anyway, the change looks good to me. It wouldn't have made sense to do
deep copies of the paths unless we were also doing deep copies of the
access batons. In the one case where it does make sense
(svn_fs_create_access), we make the deep copy.



To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-05 21:20:41 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.