[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Externals inconsistencies and feedback

From: Blair Zajac <blair_at_orcaware.com>
Date: Thu, 04 Sep 2008 07:52:00 -0700

Blair Zajac wrote:
> Karl Fogel wrote:
>> This was a no-op switch here, right? That is, you're just running it to
>> show us how 'switch' doesn't restore the missing externals dir, even
>> though 'update' would, right?
> Correct.
>>> At revision 1.
>>> $ ls wc | wc
>>> 0
>>> Another issue, in externals.c compare_external_items(), I don't think
>>> we can
>>> return that two external items are identical if either the old or new
>>> external
>>> item has a HEAD peg revision, since a new HEAD revision may have
>>> replaced the
>>> item with another item.
>> Excellent point; I cannot imagine disagreeing :-).
> OK :)
>>> So I think we should just get rid of the update_unchanged argument to
>>> svn_client__handle_externals(). We should always update externals.
>>> I can't
>>> think of a time when you wouldn't want to.
>> I wish I could remember why we added it, but what you're saying seems
>> reasonable now, yes.
> I looked through the logs to see if there was any reason to do that, but
> I couldn't find any.
> I'll make the changes.

Done in r32897.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-09-04 16:52:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.